Skip to content

Don't trigger codecov reports - #1109

Merged
mdickinson merged 2 commits into
masterfrom
ci/dont-use-codecov
May 19, 2020
Merged

mdickinson merged 2 commits into
masterfrom
ci/dont-use-codecov

Conversation

@mdickinson

Copy link
Copy Markdown
Member

This PR removes the codecov triggers from the Travis CI configuration.

Fixes #919

@kitchoi

kitchoi commented May 19, 2020

Copy link
Copy Markdown
Contributor

Thanks. There is one from appveyor.yml too.

@mdickinson

Copy link
Copy Markdown
Member Author

Thanks, fixed. I wonder whether the dual reports could be part of what's confusing codecov.io. Someday we should try to re-implement and make this useful. But not today.

@kitchoi kitchoi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread appveyor.yml
- install-edm-windows.cmd
- edm install -y wheel click coverage
- edm run -- python etstool.py install --runtime=%runtime%

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by spacing consistency nitpick

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1109 into master will decrease coverage by 1.97%.
The diff coverage is 68.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
- Coverage   76.15%   74.18%   -1.98%     
==========================================
  Files          54       79      +25     
  Lines        6493     8479    +1986     
  Branches     1263     1610     +347     
==========================================
+ Hits         4945     6290    +1345     
- Misses       1205     1810     +605     
- Partials      343      379      +36     
Impacted Files Coverage Δ
traits/api.py 100.00% <ø> (+9.67%) ⬆️
traits/base_trait_handler.py 61.76% <ø> (ø)
traits/observers/_i_notifier.py 0.00% <0.00%> (ø)
traits/observers/events.py 0.00% <0.00%> (ø)
traits/traits.py 75.10% <ø> (-2.45%) ⬇️
traits/util/resource.py 15.25% <ø> (ø)
traits/observers/_generated_parser.py 51.96% <51.96%> (ø)
traits/trait_types.py 72.29% <88.88%> (-0.16%) ⬇️
traits/observers/parsing.py 95.34% <95.34%> (ø)
traits/observers/_trait_event_notifier.py 96.61% <96.61%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd41fb2...e1bae8b. Read the comment docs.

@mdickinson

Copy link
Copy Markdown
Member Author

AAARGH!

@kitchoi

kitchoi commented May 19, 2020

Copy link
Copy Markdown
Contributor

Hmmm, that's puzzling.

@kitchoi

kitchoi commented May 19, 2020

Copy link
Copy Markdown
Contributor

Maybe because master still has the codecov setup, this needs to be merged first for this to take effect?

@kitchoi

kitchoi commented May 19, 2020

Copy link
Copy Markdown
Contributor

(it was a baseless wild guess)

@mdickinson

Copy link
Copy Markdown
Member Author

No idea. Let's merge and see what happens.

@mdickinson
mdickinson merged commit 7e77cef into master May 19, 2020
@mdickinson
mdickinson deleted the ci/dont-use-codecov branch May 19, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider ditching coverage

3 participants